TST: catch exception for div/truediv operations between Timedelta and pd.NA #58188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droussea2001
changed the title
droussea2001
changed the title
mroeschke
reviewed
Apr 8, 2024
doc/source/whatsnew/v3.0.0.rst
Outdated
| @@ -362,6 +362,7 @@ Datetimelike | |||
| Timedelta | |||
| ^^^^^^^^^ | |||
| - Accuracy improvement in :meth:`Timedelta.to_pytimedelta` to round microseconds consistently for large nanosecond based Timedelta (:issue:`57841`) | |||
| - Add a test for div and true div between ``Timedelta`` and ``pd.NA`` raising a TypeError (:issue:`54315`) | |||
There was a problem hiding this comment.
Whatsnew notes are not needed for just unit test additions
There was a problem hiding this comment.
Thanks, I just removed it
mroeschke
approved these changes
Apr 15, 2024
|
Thanks @droussea2001 |
|
You're welcome ! |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
… pd.NA (pandas-dev#58188) * *TST 54315 Add tests for pd.Timedelta and pd.NA div / truediv * Add release doc for TST 54315 * Apply pre commit correction for TST 54315 * "Correct bug fix description removed" * Remove unnecessary unit test description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This PR add a test to catch
TypeErrorraised by div and true div operations betweenTimedeltaandpd.NA.